Files
cron-checker/main.go
T
argoyle 52d52a222c
Unbound Release / Check Preconditions (push) Successful in 3s
Unbound Release / Create Tag (push) Skipped
Unbound Release / Create Release (push) Successful in 15s
Unbound Release / Generate Changelog and Handle PR (push) Successful in 17s
Release / release (push) Successful in 21s
cron-checker / test (push) Successful in 2m12s
cron-checker / vulnerabilities (push) Successful in 2m15s
cron-checker / build (push) Successful in 50s
fix: evaluate schedules in the cronjob's spec.timeZone (#428)
Schedules were always evaluated in UTC because `schedule.Next` uses the location of `lastScheduleTime`, which the API returns in UTC. A CronJob with `spec.timeZone` set was therefore reported as not running every day. For example, Paidit's `prod/dayclose` runs at `0 7 * * *` Europe/Stockholm: it ran at 05:00Z, but cron-checker expected 07:00Z and alerted every minute from 09:02 local time.

- Convert `since` to the CronJob's `spec.timeZone` before computing the next run. CronJobs without a `timeZone` behave as before.
- An invalid time zone returns an error, the same way an invalid schedule does.
- Embed `time/tzdata`, because the image is `FROM scratch` and has no zoneinfo.
- Tests: an invalid time zone, and a time-zone case that fails without the fix.
- Bumped golang.org/x/net to v0.60.0. govulncheck was already failing on main with five x/net advisories, which blocks the build job.
- Bumped the go toolchain to 1.27.2 for eight stdlib advisories. This is the same change as Renovate #427, which will close once this is merged.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

https://claude.ai/code/session_01C8SW6vsbkrTKjLNatQ8JTg
Reviewed-on: https://gitea.unbound.se/unboundsoftware/cron-checker/pulls/428
2026-10-09 07:54:30 +00:00

139 lines
3.8 KiB
Go

package main
import (
"context"
"fmt"
"io"
"os"
"os/signal"
"syscall"
"time"
_ "time/tzdata" // the image is FROM scratch, so embed zoneinfo for spec.timeZone
"github.com/alecthomas/kingpin/v2"
"github.com/multiplay/go-slack/chat"
"github.com/multiplay/go-slack/webhook"
"github.com/robfig/cron"
v1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/client-go/kubernetes"
batchv1 "k8s.io/client-go/kubernetes/typed/batch/v1"
"k8s.io/client-go/rest"
)
var (
checkFunc = doCheck
exitFunc = os.Exit
)
func main() {
slackUrl := kingpin.Flag("slack-url", "The Slack Webhook URL").Envar("SLACK_URL").Required().String()
kingpin.Parse()
exitFunc(doMain(*slackUrl, &DefaultProvider{&InClusterProvider{}}))
}
func doMain(slackUrl string, provider ClientProvider) int {
client, err := provider.Provide()
if err != nil {
fmt.Printf("Unable to connect to K8S: %s\n", err)
return 1
}
ic := make(chan os.Signal, 1)
signal.Notify(ic, os.Interrupt, syscall.SIGTERM)
if err := checkFunc(client, slackUrl, ic, 60*time.Second, os.Stdout); err != nil {
fmt.Printf("Error checking jobs: %s\n", err)
return 1
}
return 0
}
func doCheck(client Client, slackUrl string, ic chan os.Signal, sleepTime time.Duration, out io.Writer) error {
slack := webhook.New(slackUrl)
parser := cron.NewParser(cron.Minute | cron.Hour | cron.Dom | cron.Month | cron.Dow)
for {
select {
case <-ic:
_, _ = fmt.Fprintf(out, "Got SIGTERM signal, exiting\n")
return nil
default:
cronJobs, err := client.BatchV1().CronJobs("").List(context.Background(), v1.ListOptions{})
if err != nil {
return fmt.Errorf("error getting cronjobs: %w", err)
}
limit := time.Now().Add(-120 * time.Second)
for _, c := range cronJobs.Items {
if c.Spec.Suspend == nil || !*c.Spec.Suspend {
since := c.CreationTimestamp
if c.Status.LastScheduleTime != nil {
since = *c.Status.LastScheduleTime
}
// The schedule is evaluated in the location of since, so use the cronjob's time zone (UTC if unset)
if c.Spec.TimeZone != nil {
loc, err := time.LoadLocation(*c.Spec.TimeZone)
if err != nil {
return fmt.Errorf("error loading time zone of %s/%s (%s): %w", c.Namespace, c.Name, *c.Spec.TimeZone, err)
}
since = v1.NewTime(since.In(loc))
}
schedule, err := parser.Parse(c.Spec.Schedule)
if err != nil {
return fmt.Errorf("error parsing schedule of %s/%s (%s): %w", c.Namespace, c.Name, c.Spec.Schedule, err)
}
next := schedule.Next(since.Time)
_, _ = fmt.Fprintf(out, "Checking %s/%s since %s, next schedule %s, limit %s.\n", c.Namespace, c.Name, since.Format(time.RFC3339), next.Format(time.RFC3339), limit.Format(time.RFC3339))
if next.Before(limit) {
_, _ = fmt.Fprintf(out, "%s/%s was not scheduled. Sending Slack notification.\n", c.Namespace, c.Name)
m := &chat.Message{
Text: fmt.Sprintf("Cronjob %s/%s is not running according to schedule (%s). Last scheduled: %s", c.Namespace, c.Name, c.Spec.Schedule, since.Format(time.RFC3339)),
Username: "cron-checker",
}
_, err := m.Send(slack)
if err != nil {
_, _ = fmt.Fprintf(out, "Unable to send Slack notification: %s\n", err)
}
}
}
}
time.Sleep(sleepTime)
}
}
}
type Client interface {
BatchV1() batchv1.BatchV1Interface
}
type ClientProvider interface {
Provide() (Client, error)
}
type DefaultProvider struct {
provider ConfigProvider
}
func (d DefaultProvider) Provide() (Client, error) {
config, err := d.provider.Provide()
if err != nil {
return nil, err
}
return kubernetes.NewForConfig(config)
}
var _ ClientProvider = &DefaultProvider{}
type ConfigProvider interface {
Provide() (*rest.Config, error)
}
type InClusterProvider struct{}
func (i InClusterProvider) Provide() (*rest.Config, error) {
return rest.InClusterConfig()
}
var _ ConfigProvider = &InClusterProvider{}