From 7d2773f6a1cbcc988c903efed5b81caa63e50546 Mon Sep 17 00:00:00 2001 From: Joakim Olsson Date: Wed, 7 Oct 2026 19:25:32 +0000 Subject: [PATCH] fix(monitoring): use otel.SetLoggerProvider (#998) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit opentelemetry-go v1.47.0 (#990) deprecates `go.opentelemetry.io/otel/log/global`. staticcheck SA1019 in `golangci-lint-full` now fails pre-commit on every PR (e.g. #997). Swap `global.SetLoggerProvider` for `otel.SetLoggerProvider` and drop the import. `go mod tidy` marks `otel/log` indirect. Locally: `golangci-lint-full` passed, `go test ./...` passed. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01Ma8eHhW59hLAJuLzBnLvUu Reviewed-on: https://git.unbound.se/unboundsoftware/schemas/pulls/998 --- go.mod | 2 +- monitoring/otel.go | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/go.mod b/go.mod index 44eff6f..70e761f 100644 --- a/go.mod +++ b/go.mod @@ -26,7 +26,6 @@ require ( go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp v1.47.0 go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp v1.47.0 go.opentelemetry.io/otel/exporters/stdout/stdoutlog v0.23.0 - go.opentelemetry.io/otel/log v1.47.0 go.opentelemetry.io/otel/sdk v1.47.0 go.opentelemetry.io/otel/sdk/log v1.47.0 go.opentelemetry.io/otel/sdk/metric v1.47.0 @@ -81,6 +80,7 @@ require ( github.com/wundergraph/go-arena v1.3.0 // indirect go.opentelemetry.io/auto/sdk v1.2.1 // indirect go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.47.0 // indirect + go.opentelemetry.io/otel/log v1.47.0 // indirect go.opentelemetry.io/otel/metric v1.47.0 // indirect go.opentelemetry.io/proto/otlp v1.11.0 // indirect go.uber.org/multierr v1.11.0 // indirect diff --git a/monitoring/otel.go b/monitoring/otel.go index 8229cd2..0830383 100644 --- a/monitoring/otel.go +++ b/monitoring/otel.go @@ -12,7 +12,6 @@ import ( "go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp" "go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp" "go.opentelemetry.io/otel/exporters/stdout/stdoutlog" - "go.opentelemetry.io/otel/log/global" "go.opentelemetry.io/otel/propagation" "go.opentelemetry.io/otel/sdk/log" "go.opentelemetry.io/otel/sdk/metric" @@ -75,7 +74,7 @@ func SetupOTelSDK(ctx context.Context, enabled bool, serviceName, buildVersion, processor := log.NewSimpleProcessor(logExporter) logProvider := log.NewLoggerProvider(log.WithProcessor(processor)) - global.SetLoggerProvider(logProvider) + otel.SetLoggerProvider(logProvider) shutdownFuncs = append(shutdownFuncs, logProvider.Shutdown) exp, err := otlpmetrichttp.New(ctx)