shiny/authz_client
6
0 Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases 14 Activity

fix!: order privilege events by sequence number and merge snapshots by position #333

Merged
argoyle merged 1 commits from fix/sequence-ordered-privileges into main 2026-09-16 18:36:09 +00:00
Conversation 1 Commits 1 Files Changed 4
+693 -142
1 Commits
Author SHA1 Message Date
argoyleandClaude Opus 5 84e9309901 fix!: order privilege events by sequence number and merge snapshots by position
authz_client / test (push) Skipped
authz_client / vulnerabilities (push) Skipped
pre-commit / pre-commit (push) Skipped
authz_client / vulnerabilities (pull_request) Successful in 1m0s
Details
authz_client / test (pull_request) Successful in 1m10s
Details
pre-commit / pre-commit (pull_request) Successful in 3m47s
Details 
The four privilege keys arrive on separate transient queues, so a late
Privilege.Added or User.Added could resurrect a revoked grant. Services also
fetched /authz before binding their queues, losing revocations published in
between.

Process now orders events by authz-service's global sequenceNo per
(email, company): an event only overrides older facts, User.Removed stamps
every privilege, and events without a sequence number fail closed (additions
dropped, removals held until the next snapshot). Fetch checks the status,
retries 503 while authz-service's read view is behind, reads the
X-Authz-Sequence header and merges the snapshot as facts at that position,
ignoring snapshots older than one already merged. CompaniesByUser returns []
instead of nil.

BREAKING CHANGE: events without SequenceNo no longer grant anything; tests that
seed the handler through Process must set SequenceNo. Call Fetch() after
conn.Start (ADR-0015).

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DVGsVQ8AMFR4NZoxyCoEqS
 2026-09-16 20:27:28 +02:00